Small patch needed to compile liblqr on Mac OS: change upstream package?

Small patch needed to compile liblqr on Mac OS: change upstream package?

Vlado Plaga (guest) 16 Jul 2009 08:52

Hi,
being a relatively new "digiKam fan and user", I'm trying to create a "Portfile" for digiKam for the MacPorts project.
Now digiKam 1.0 beta 2 comes with a private version of your liblqr (version 0.4.1). This library does not compile on Mac OS without a little patch.
The patch is to remove the "inline" keyword in two lines. I tested that patch on Linux, and liblqr still compiles. I don't know if it affects functionality or security, though. But if you think it is ok to do so, I'd suggest you apply these changes to the next release, so that liblqr and digiKam 1.0 in the future can compile on Mac OS without any extra patches.

Re: Small patch needed to compile liblqr on Mac OS: change upstream package?

CarloB 17 Jul 2009 02:56

Thanks a lot for the report and for the suggestion, in fact I was already aware of that problem: I just need to test the performance (which is the only aspect which may be affected) of the library without the inlines and if everything goes fine I will just remove them, otherwilse I'll add some special compilation rule for OSX.
By the way, if you or anyone else knows the reason for the compilation failure on Mac OSX and how to prevent such problems in the future please let me know, thanks.